search

patw0929 / react-intl-tel-input

Rewrite International Telephone Input in React.js. (Looking for maintainers, and PRs & contributors are also welcomed!)
https://patw0929.github.io/react-intl-tel-input/
MIT License
283 stars 222 forks source link

Out of date validation for Singapore phone number #331

Open haitrr opened 4 years ago

haitrr commented 4 years ago

This error is due to the package libphonenumber-js-utils is out of date compare to Google's libphonenumber. The phone number format for Singapore has changed: https://github.com/google/libphonenumber/pull/2402

Expected Behavior

+6589234567 should be a valid phone number for Singapore

Current Behavior

+6589234567 is not a valid phone number for Singapore.

Possible Solution

Upgrade libphonenumber-js-utils to sync with the latest libphonenumber.

Environment

mcataford commented 4 years ago

Hi @vroyibg ! Thanks for bringing this up! I'll go forward with an update for the underlying phone number library today.

mcataford commented 4 years ago

The underlying library was updated, should address the issue. I'll add in some follow-up around managing those dependencies automatically to avoid this in the future.

athrunsun commented 3 years ago

It is now 2021 and the issue still exists for new SG phone number starting with "89" like 89089790.

athrunsun commented 3 years ago

@patw0929 @mcataford Help! Anyone still maintaining this lib? We need to update libphonenumber-js-utils for new SG phone numbers.

RaiKouz759 commented 2 years ago

Any updates on this?