bug vs country code - Githubissues

patw0929 / react-intl-tel-input

Rewrite International Telephone Input in React.js. (Looking for maintainers, and PRs & contributors are also welcomed!)

https://patw0929.github.io/react-intl-tel-input/

MIT License

283 stars 222 forks source link

bug vs country code #355

Closed TarasKhust closed 3 years ago

TarasKhust commented 4 years ago

Description

Screenshots (if appropriate):

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have used ESLint & Prettier to follow the code style of this project.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

iivmok commented 3 years ago

ISO 3166 country code for United Kingdom is "GB", this fix is wrong

mcataford commented 3 years ago

@iivmok Is right on that one.

@TarasKhust I'd love to know more about what motivated the change proposal. If you'd like to chat more on it, please do open an issue. In the meantime, I'm going to close this PR since it doesn't include a description / discussion of the change and includes broken info.