patw0929 / react-intl-tel-input

Rewrite International Telephone Input in React.js. (Looking for maintainers, and PRs & contributors are also welcomed!)
https://patw0929.github.io/react-intl-tel-input/
MIT License
283 stars 222 forks source link

build: replaces node-sass with sass #381

Closed mcataford closed 3 years ago

mcataford commented 3 years ago

Description

node-sass is now deprecated and the suggested replacement is dart-sass. This substitutes one for the other. Major pro for this: node-sass did some heavy node-gyp building whereas this doesn't, making building-from-scratch way faster.

Screenshots (if appropriate):

Types of changes

Checklist:

mcataford commented 3 years ago

QA: diff'ed CSS output before and after the change, they are functionally the same. sass seems to insert a handful of extra newlines, but otherwise, same stylesheet. :+1:

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 8.0.5 :tada:

The release is available on:

Your semantic-release bot :package::rocket: