refactor: remove `tsd` integration

andrewsantarin commented 3 years ago

This PR discards the usage of tsd in tests because it has very limited use in this library at the moment.

Resolves https://github.com/patw0929/react-intl-tel-input/pull/389#discussion_r688971979

Description

Removed tsd usage, dependency and mention.
Removed "TypeScript usage" from the doc to simplify readability.
Improved linting in TypeScript tests.

Screenshots (if appropriate):

Not required. This is a development workflow change.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have used ESLint & Prettier to follow the code style of this project.
[x] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

andrewsantarin commented 3 years ago

One other thing:

The point of having additional TypeScript tests was to ensure that the declarations worked just as advertised. I do realize that this could be overkill for a library that is still written in plain JavaScript. I rushed quickly into ensuring that the TypeScript side doesn't go to public with at least some quality assurance.

So, in the spirit of keeping things lean, perhaps just dropping the .test.ts files altogether sounds about good right now.

consolidating the ts/js tests

If we had to introduce TypeScript to tests here, some supplementary (NOT replacement!) tooling for it is in order, e.g. ts-jest. I do use this at work and it has worked pretty well so far. We don't have to address it right here right now if this is a huge scope creep. I'm glad that we made it to official TypeScript support at this rate.

mcataford commented 3 years ago

100% on ts-jest. Let's do that as a follow up!

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 8.1.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

patw0929 / react-intl-tel-input