search

patw0929 / react-smartbanner

Rewrite Smart App Banner in React.js.
https://patw0929.github.io/react-smartbanner/
MIT License
74 stars 56 forks source link

iOS native smart banner shows on top of this smart banner #23

Closed imdongchen closed 7 years ago

imdongchen commented 7 years ago

Safari has a built in feature that reads the same format meta tag and shows the smart banner. This causes the web to show two banners

https://developer.apple.com/library/content/documentation/AppleApplications/Reference/SafariWebContent/PromotingAppswithAppBanners/PromotingAppswithAppBanners.html

patw0929 commented 7 years ago

I'm using iOS 10.3.3 & Safari, it seems ok, only the native smart banner shown up. Could you provide more information about this issue? Thanks!

imdongchen commented 7 years ago

I think the native smart banner should be disabled. Otherwise we will be seeing two banners, like below (using iPhone Safari):

img_6642 png

This issue has been reported here as well: https://github.com/kudago/smart-app-banner/pull/60

patw0929 commented 7 years ago

I'm curious about the smartbanner (js) is shown automatically? Or it's shown by clicking the iOS button? (force to change smartbanner type)

Related pr: #12

imdongchen commented 7 years ago

Yes this react-smartbanner is shown by clicking the iOS button, and the native banner is shown automatically. I think when we want to show the react-smartbanner, the native banner should be disabled, right?

patw0929 commented 7 years ago

I made a PR #24, could you help me to review? Thanks!