search

patw0929 / react-smartbanner

Rewrite Smart App Banner in React.js.
https://patw0929.github.io/react-smartbanner/
MIT License
74 stars 56 forks source link

add close and install callback #27

Closed imdongchen closed 7 years ago

imdongchen commented 7 years ago

Issue #25

Add callback to clicking actions

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 85.714% when pulling 6afcc416b690a07aab9ce200fcd6a3e7ed4faf41 on cdbean:click-callback into 17e5be9f774d76a2ab479323ead0e4228c099e6a on patw0929:master.

imdongchen commented 7 years ago

Coverage... 🤔

patw0929 commented 7 years ago

Thanks! Looks good to me! 🎉 There is another thing have to do, could you help to update the index.html about the new props onClose&onInstall`?

imdongchen commented 7 years ago

Sure thing! Added ✅

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 85.714% when pulling e15ef4549f29e5e5d9452ab107a57968d8e12746 on cdbean:click-callback into 17e5be9f774d76a2ab479323ead0e4228c099e6a on patw0929:master.