search

patw0929 / react-smartbanner

Rewrite Smart App Banner in React.js.
https://patw0929.github.io/react-smartbanner/
MIT License
74 stars 56 forks source link

Bad or partial release #33

Closed poorpaddy closed 6 years ago

poorpaddy commented 6 years ago

It looks like the dist files didn't get properly generated for v5.0.0. The dist/main.js file shows the old this.props.url and main.css isn't being generated at all.

Double checked clearing both npm & yarn cache and nuked node modules each time.

d7laungani commented 6 years ago

I have this issue as well and I am getting the latest release that your fix has. What do I do since main.js is showing up but the main.css is not being generated. Thanks.

poorpaddy commented 6 years ago

@patw0929 would need to republish it to npm.

patw0929 commented 6 years ago

Sorry for the bad release. I'm commuting, and I'll handle it later.

patw0929 commented 6 years ago

Hey guys, I've released fixed version v5.0.4. Could you help to verify it? Thanks!

poorpaddy commented 6 years ago

Looks like it's creating the dist folder correctly now. Confirmed to be working.