search

patw0929 / react-smartbanner

Rewrite Smart App Banner in React.js.
https://patw0929.github.io/react-smartbanner/
MIT License
74 stars 56 forks source link

iOS 11 Shows both banners #35

Open poorpaddy opened 6 years ago

poorpaddy commented 6 years ago

iOS shows both the native Safari smart banner and react-smartbanner. Not sure of the solution yet but an idea would be to remove the dependency of the meta tags.

albertoperezf commented 6 years ago

I check this using a real iOS 11 device (iPhone 7 Plus with iOS 11.2.6) and Safari and no problem at all (Already tested in local server & BrowserStack), the actual banner that shows up is the native one and the smartbanner is hidden.

whatsapp image 2018-03-12 at 2 02 24 pm

If you remove the meta tags from the project is probably that the smartbanner don't go at all. We have to wait for the main developer comments about this issue.

patw0929 commented 6 years ago

Thanks for testing! @albertoperezf I tested on iPad mini 2 (iOS 10.3.3) and it works fine too.

img_0164

@poorpaddy Could you provide more information about the situation?

albertoperezf commented 6 years ago

This issue is in fact duplicated (#23) and close after @patw0929 make a PR. Maybe @poorpaddy you could give us more info about you're dev environment (Device, iOS version) or how you are using the Smartbanner.

poorpaddy commented 6 years ago

I've narrowed it down to it occuring when ignoring iOS version to always show custom smartbanner instead of iOS. I ended up just writing my own smartbanner because the meta and icon dependency is just too embedded into this package.