search

patw0929 / react-smartbanner

Rewrite Smart App Banner in React.js.
https://patw0929.github.io/react-smartbanner/
MIT License
74 stars 56 forks source link

Allow button prop to accept anything that can be rendered #37

Closed kevin-miles closed 6 years ago

kevin-miles commented 6 years ago

This is to allow the button prop to accept anything that can be rendered: numbers, strings, elements or an array (or fragment) containing these types in order to prevent failed prop type warnings in the scenario the developer would like to pass in those types.

Thanks for your work on react-smartbanner Patrick!

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 82.692% when pulling 733b04085f33f3a56bab38befc03380ac8d31aa7 on kevin-miles:master into 52f615926cf45d4968128ac3dd549d0effb72af5 on patw0929:master.

patw0929 commented 6 years ago

Merged. Thank you! 🙌