search

patw0929 / react-smartbanner

Rewrite Smart App Banner in React.js.
https://patw0929.github.io/react-smartbanner/
MIT License
74 stars 56 forks source link

Cannot develop or commit. #38

Open vince1995 opened 6 years ago

vince1995 commented 6 years ago

Hey, I can't develop on your repo. When I do npm install it shows me No matching version found for webpack@beta. Solved this by setting webpack to 3.10.0.

When I want to commit it shows me ./node_modules/pre-commit/hook: line 49: : command not found.

patw0929 commented 6 years ago

Question 1:

Ah, I think that's because I forgot to make a package version lock file for npm install (like the yarn.lock as yarn). Is it package-lock.json? (I usually use yarn recently, so I'm not sure what's for npm.) I made it for test, but it's seems like not working for me. It got the Cannot read property 'match' of undefined issue. Maybe we should just revise the webpack's version to ^3.10.0 in package.json. What do you think?

Question 2:

Could you find how to solve it at pre-commit's repo? It looks like that it's a setting issue.