Make close a button for accessibility

patw0929 / react-smartbanner

Rewrite Smart App Banner in React.js.

https://patw0929.github.io/react-smartbanner/

MIT License

74 stars 56 forks source link

Make close a button for accessibility #43

Closed aschleicher2 closed 5 years ago

aschleicher2 commented 5 years ago

The browser does not recognize <a /> tag without href prop as a focusable element, so I am changing it to a button for accessibility. Currently, I cannot access the close button using the keyboard, and my company's website has to be keyboard accessible.

patw0929 commented 5 years ago

Good point! But could you help to solve the conflict? Thanks!

aschleicher2 commented 5 years ago

@patw0929 Conflicts resolved!

patw0929 commented 5 years ago

Thanks! Merged and published as 5.1.1.