search

patw0929 / react-smartbanner

Rewrite Smart App Banner in React.js.
https://patw0929.github.io/react-smartbanner/
MIT License
74 stars 56 forks source link

Fixed #46: Webpack UDM issue #47

Closed patw0929 closed 5 years ago

patw0929 commented 5 years ago

In v5.1.2, we upgraded webpack to v4, so we might get an error: window is not defined in SSR. In webpack's issue, we found a workaround of this issue. (https://github.com/webpack/webpack/issues/6522#issuecomment-371120689)

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 80.588% when pulling 60e20bb4b0ec867066e269f76de71b9b698f7372 on fix/webpack4-window-issue into e5937b807aadc1113c73f53a143d8b985a5d34dd on master.