patzly / grocy-android

ERP beyond your fridge, now on your phone – An awesome companion app for grocy
https://patrickzedler.com/grocy/
GNU General Public License v3.0
892 stars 85 forks source link

Mark new one as opened as well #572

Open PetrP2B opened 2 years ago

PetrP2B commented 2 years ago

Hi, great job! I would like to ask if it would be possible to add a "mark as open" quick dial button to the Consume page. Ideally next to the "consume" button. It used to be, and then this option moved to a checkbox. But mostly we need to quickly click on open. Thank you

dominiczedler commented 2 years ago

Hi, maybe you don't know the faster way for opening items: On the stock overview page you can swipe an item to the right and tap on open. Or you tap on the item and then on the bottom sheet on the open button.

Did you know this way and do you still want the quick possibility on the consume page?

PetrP2B commented 2 years ago

Hi, I'll admit I didn't know about that, but I still think it's faster and more user-friendly to click "Consume", then scan the barcode, then click "Open". If I use the "Overview" page, then click on the magnifying glass, then scan and swipe to the right, it's still more steps ;-).

martin-braun commented 1 year ago

I noticed, the quick mode will always consume, this can lead to undesirable effects for unexperienced users. Without quick mode it's not that hard to work with. Not checking any checkbox will consume the item, checking "mark product open" will open it instead.

I also think it would be beneficial to prompt for either of those actions in quick mode. A lot of stuff cannot be consumed instantly and it's not like we have to consume a lot of things at once.

dominiczedler commented 1 year ago

I think this is a good solution, thanks for your idea @martin-braun! @PetrP2B This solution is like "Consume (quick) -> scan barcode -> confirmation page appears -> tap open -> let progress bar fill automatically and open action will happen"

martin-braun commented 1 year ago

@dominiczedler nicely done. Beautiful. I'm using grocy for a few days now and I noticed another problem with the work-flow:

I open a lot of items that I consumed. I.e. a Deodorant is empty suddenly, so I open a new one and throw the old away. This means I have to consume the item and mark another one as open.

This results in scanning items twice, often. Maybe it was possible to add a third option, but only if the selected amount is 1 and at least 1 item is opened at the moment?

I.e. ( Consume | Mark as opened | Consume and open next ). Alternatively, having a checkbox below the radio group called [ ] Mark new one as opened as well which will only be visible based on the conditions mentioned above as well as if Consume is selected.

Please tell me what you think?

Thanks a lot.

Saturo78 commented 1 year ago

This behavior is really slowing me down. I always have to wait before next scan. Can it be disabled by a settings option because i don´t need it.

patzly commented 1 year ago

@Saturo78 Please keep things in context here, your comment doesn't seem to be related to the previous comments as the solution was already found and implemented. The reason why this issue is still opened is the wish for an extra button to directly mark the next available product as opened. What don't you need there or what should be disabled? The issue itself is already solved, so it's probably not a good idea to use it for commenting other problems.

Saturo78 commented 1 year ago

My comment referers to this entry.

I think this is a good solution, thanks for your idea @martin-braun! @PetrP2B This solution is like "Consume (quick) -> scan barcode -> confirmation page appears -> tap open -> let progress bar fill automatically and open action will happen"

I do not think this is a good solution for everyone. Sorry for the confusion.

dominiczedler commented 1 year ago

Okay, but if you have a problem with the confirmation dialogue in general then this is a topic for another issue and if you have a problem with the "open" solution like on the screenshot, you could explain why you don't like it.

Edit:

I always have to wait before next scan

Why wait? Just press Proceed and all is good