patzly / grocy-android

ERP beyond your fridge, now on your phone – An awesome companion app for grocy
https://patrickzedler.com/grocy/
GNU General Public License v3.0
879 stars 85 forks source link

Buttons are asymmetrical #703

Closed VNRARA closed 1 year ago

VNRARA commented 1 year ago

Screenshot_20230521_050303_Grocy

dominiczedler commented 1 year ago

Creating such an issue is ridiculous. Please focus on the important things, we did that because the buttons are all arranged to the right on the home page. If you really think this is an issue, please describe it in a way we can understand the reason. Thank you for using our app.

VNRARA commented 1 year ago

It's two second worth of work in Android studio. Idk how to pr or I'd do it myself. Left margin is not the same as the buttons in the other part above. You focus on a beautiful app and then do stuff like this. Alignment to the right doesn't make sense in anyway.

Screenshot_20230522_151325_Grocy

dominiczedler commented 1 year ago

Wow, you're such a grateful person. Right alignment is our decision and if you don't agree with that you can use the website of the server.

If you would think about it, you would notice that the buttons are arranged in a horizontal ScrollView, which is scrollable as soon as the width is not enough for the buttons. The distance to the left edge doesn't matter at all, because it is dynamic.

VNRARA commented 1 year ago

It doesn't make sense when two buttons just don't scroll and are an eyesore. It's even more of an eyesore on the samsung A41. And thanks for the ad hominem.. 👌🏽

patzly commented 1 year ago

@VNRARA The right-aligned buttons are a common design practice in the Material 3 guidelines, e. g. in M3 dialogs the title is left-aligned like in our cards and to make things compensated for the eye the bottom buttons are right-aligned. As my brother said, the buttons are to long for some languages so we had to make them scrollable. The right padding on the left side is included, but only when scrolled to the left edge of the last button exactly like in the stock overview card. An outer margin for container like you want would cut off the buttons.

VNRARA commented 1 year ago

You mention dialog boxes which usually have 2 options or 3 max. Middle and Right or Left Middle Right (equidistant).

It doens't make sense to scroll more to the right AND align to the right as if it were RTL instead of LTR. Also

image

If I just roughly compare the guide to this it still doesn't make sense.

image

patzly commented 1 year ago

Screenshot 2023-05-22 at 17 52 40

VNRARA commented 1 year ago

android:layout_gravity="start" or something

Is much better for the eye on the main layout list where everything is more cramped. But hey, maybe I'm just a "surgeon".

image