Fix price factors - Githubissues

patzly / grocy-android

ERP beyond your fridge, now on your phone – An awesome companion app for grocy

https://patrickzedler.com/grocy/

GNU General Public License v3.0

830 stars 80 forks source link

Fix price factors #809

Closed alkuzman closed 6 months ago

alkuzman commented 7 months ago

Stock overview: API changed the qu_factor_purchase_to_stock is no longer available in product + plus use PriceQU instead of PurchaseQU
Shopping list: the list entry always returns the amount in StockQU but the code assumes that it will change depending on the QU specified on the item.

This PR should close: #743, #742 and #757

alkuzman commented 7 months ago

I am not sure whether this code will be backward compatible since I started using Grocy since v4.0.1. Please let me know, and I will update the PR accordingly.

dominiczedler commented 6 months ago

Okay I will remove the support for the old versions, this is too complicated to support such old ways with convertion and unfitting product properties... 🥲 But it was annoying anyway.

alkuzman commented 6 months ago

If you want, I will give it another try, but I have to try old servers to see what's missing. I guess the resolved conversions are the biggest issue.

alkuzman commented 6 months ago

If you have an old database, it would be great if you could share it.

dominiczedler commented 6 months ago

No this is fine I think, it makes no sense to support old versions for such a long time after release of newer versions. Additionally we don't have much time anyway, so it makes development and change of things harder for us...