patzly / tack-android

A beautiful metronome for Android with a powerful Wear OS integration
https://patrickzedler.com/tack/
174 stars 7 forks source link

add option to highlight the current beat. fixes #39 #40

Open ValYouW opened 3 weeks ago

ValYouW commented 3 weeks ago

This is a working suggestion on how to implement it, not sure if it follows your practices though...

patzly commented 3 weeks ago

Thanks a lot for your contribution! I already thought a lot about your feature request but couldn't find a sufficent solution yet. Your implementation works, but I think the error color is already occupied by the emphasized beats, which wasn't enough contrast before. That's why I combined the beat type colors with the fill types outlined, semi-filled and filled. But this doesn't work as the current beat indicator, too, we need another type of indicator I think. I will experiment with this as soon as I have time. The next update will have a solution included for sure!

ValYouW commented 2 weeks ago

Yeah, I am not good at picking colors, and there are several themes so I just picked some existing color as an example...