search

pau101 / Fairy-Lights

A Forge mod for Minecraft: Java Edition that which introduces hanging lights and other decorations.
https://minecraft.curseforge.com/projects/fairy-lights
MIT License
37 stars 30 forks source link

Letter Buntings Recipe Uses Bad Data Tags #127

Open Kalikars opened 3 years ago

Kalikars commented 3 years ago

Version: 4.0.5-1.16.5

Issue: Crafting a letter bunting gives a bad text field, meaning that the letter bunting cannot fully be placed. This does not happen when using the letter bunting obtained from the creative menu.

Steps to Reproduce: 1) Craft a letter bunting. Notice the text field is filled as a malformed JSON string. 2) Attempt to right click the bunting on the ground. Notice that it immediatedly pops off and won't proceed with the second anchor point placement.

Work-around: I fixed this issue by writing a Crafttweaker script which gives the player a letter bunting with an empty text string. Note that this does not replicate the expected behavior of opening the text editor when placing the second anchor, as a normally formed letter bunting should do. See my work-around script here.

Proposed solution: Rewrite the recipe result to have a text tag similiar to the one in the creative menu.

jexom commented 3 years ago

To add to this, it is the same issue addressed in #110 which was closed because it's a duplicate of itself. Another workaround is that the check is not in place when replacing the bunting. You're able to replace the bunting and then change the text normally. After breaking the correct bunting, you can place it anywhere as expected

winderine commented 1 year ago

This is still an issue in the 1.18.2 version included in the Vault Hunters 3 Modpack. Letter Bunting cannot be used because it does not place.

agentely commented 1 year ago

This is still an issue in 1.18.2 V5.0.0