pau101 / Fairy-Lights

A Forge mod for Minecraft: Java Edition that which introduces hanging lights and other decorations.
https://minecraft.curseforge.com/projects/fairy-lights
MIT License
37 stars 30 forks source link

Optifine prevents hanging lights, bunting, and tinsel from rendering #145

Open SteampunkSquid opened 1 year ago

SteampunkSquid commented 1 year ago

When playing with Optifine, the hanging lights, bunting, and tinsel can't be properly placed. Trying to do so will simple place a fastener with nothing attached to it, and nothing drops when the fasteners are broken. Removing Optifine allows them to work correctly, but if Optifine is re-added, any lights, etc. are deleted. There doesn't seem to be any setting with Optifine that can be turned on or off to prevent this. ETA: This only seems to affect the string decorations. Placing individual lights works as expected.

MC version: 1.19.2 Forge version: 43.1.52 Fairy Lights version: 6.0.0 Optifine version: OptiFine HD U I1 pre4

2022-12-02_20 48 00 Without Optifine

2022-12-02_20 52 00 After adding Optifine to the mods folder

gfrewqpoiu commented 1 year ago

My gf is having the same issue, the only way seems to remove OptiFine and instead use Rubidium and other mods to "replace" the functionality and improvements of OptiFine. OptiFine rewrites vasts chunks of the Minecraft Rendering Pipeline which is why many modders don't particularly like it. Still, I would love to see it fixed since at least in our testing, Rubidium doesn't enhance performance nearly as much as OptiFine

gfrewqpoiu commented 1 year ago

Also, turning off anisotropic filtering, like in #132 sadly doesn't work.

Lozf commented 1 year ago

I'm having the same issue.

CreepinCreeperMinesweeper commented 1 year ago

i have the same issue thank you for pointing out that it is optifine

MithMax commented 1 year ago

Same happening here. Hopefully when Optifine has a release version for 1.19.2 forge it will fix this since it hasn't been an issue in the past with fairy lights.

gfrewqpoiu commented 1 year ago

One thing that we found out kinda works, if you string the lights between fence post pillars, it works fine, even with optifine, seems like it renders them differently.

Lozf commented 1 year ago

I just tried this gfrewqpoiu, and it worked!!!!! So awesome. Thanks!

SteampunkSquid commented 1 year ago

One thing that we found out kinda works, if you string the lights between fence post pillars, it works fine, even with optifine, seems like it renders them differently.

Huh, how weird. Hopefully attaching them to full block can be fixed, then

Secretcodrin commented 1 year ago

Today, 28.07 I had encountered this problem as well. However I swear it worked for a while.