search

pau101 / Wings

A Forge mod for Minecraft: Java Edition which adds wings for aerial travel.
https://www.curseforge.com/minecraft/mc-mods/wings
MIT License
26 stars 29 forks source link

[Suggestion]Wings consume minerals to repair themselves #19

Open dragon-evol opened 5 years ago

dragon-evol commented 5 years ago

While I am playing this mod (fantastic one among numerous flight mods), I found several slightly unreasonable things:

  1. Fairy dusts and amethysts are literally useless besides making wings (which consumes just a few of them), and those minerals just began piling up in the chests.
  2. Wings are very durable (even the easy ones last for a long long time).
  3. Flight drains hunger at a horrible rate.

So I consider it reasonable to decrease the wings' durability and the rate of exhaustion. Instead, the wings use those minerals to repair themselves automatically. I think this might make the mod have a better experience (just personal ideas).

Possible solutions:

I tried to fork it by myself, but encountered some issues about imports (failed at the beginning) due to the lack of java knowledge. :( But I think adding something like "search minerals in player's inventory if item damage is too high" in the item class which is triggered on update will work.

Update: (Checked some other issues and your replies) Even not adjusting the rate of exhaustion (just make the wings less OP by letting them consume minerals during flight) is also good!

Update again: (Checked even earlier issues and understood the reason behind these questions) Maybe this alteration can be put into config? Just to provide some welfare for miners. (The exhaustion mechanic seems to prefer farmers?)

Hope the mod will become better and better!

dragon-evol commented 5 years ago

Spent hours on it, finally finished the alternative mode myself...

Victory of the dumb! :)

This issue will become a pull request!

jreneias commented 5 years ago

dragon-evol: How did you manage to do that?

dragon-evol commented 5 years ago

dragon-evol: How did you manage to do that?

Actually I still don't know how this mod works, just managed to change some numbers (variables, constants), inserted a little method into a place that will be fired each tick (well, I found something called 'onUpdate' in those codes, whose name speaks everything), and added a new config imitating the present ones.

Most important things are in the 'ItemWings.class'. In fact, if you don't want to deal with the config things, all concerning things are in this file.

There are many things besides how the item itself behaves, such as the model, animation, motion, so making an alteration like this is not so horrible... figuring out how the whole mod works (registration, model, texture, when are each piece of codes fired, how they interact, etc) is really challenging. (like... the difference between cutting a branch and chopping the tree?)

(of course the library thing is also frustrating...)

touhouzun commented 5 years ago

Fairy dusts and amethysts are literally useless besides making wings (which consumes just a few of them), and those minerals just began piling up in the chests.

That's the key problem.I agree dragon-evol's idea. @dragon-evol

If I were you,I would have these plans:

REMOVE fairy dust ore and amethyst ore.It's really unnecessary to add ores when you make new recipes for your mod's just few items.Wings is a utility mod,not a large tech/magic mod after all.

Instead,fairy dust can be obtained from hostile mobs' loots(very very rare),dungeon loots,and boss mobs' drops(e.g. ender dragon and wither,you can get enough there).

Also evil wings should be crafted by using two emeralds instead of emerald+amethyst.Amethyst is only used in few mods like Biomes o' plenty&pewter.There's no reason to add your own.

Drinkable bat blood,sounds out of our plans but funny,see https://github.com/pau101/Wings/issues/16

Hope Mr.(?)@pau101 could take a look.Have nice days!:)

p.s. Chinese player,not very good at english,may have mistakes.(:з)∠)