automatic/emacs.portable Modify chocolateyInstall.ps1 and Update Package

aproposts commented 10 months ago

Description

The package tests were failing because the zips for 29.1 don't have the emacs-$version pattern of earlier releases. I changed the install script to account for the change then ran the AU update.ps1.

Motivation and Context

It fixes the issue for 29.1, but it's probably a breaking change for earlier versions, not sure how you'd want to handle that.

https://github.com/pauby/ChocoPackages/issues/199

How Has this Been Tested?

I forked this repo, mucked around a bit before finding out the structure of the new and old emacs zips are different. After that, it was pretty clear to modify the parameters sent to Get-ChocolateyUnzip, run the AU update.ps1 and run choco install emacs.portable --debug --verbose --source . from the emacs.portable directory without issue.

Tested on Windows 10 Pro

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this repository (if your change does not follow the style it will likely be rejected - this includes changes in formatting / layout).
[x] I have updated the package description and it is less than 4000 characters.
[ ] The added / modified package passed install / uninstall in the chocolatey test environment. I didn't have the time to setup the test environment; but before success, I was getting the same errors as the failed tests for 29.1
[x] The changes only affect a single package (not including meta package).

pauby commented 10 months ago

Thanks for the PR. I'm not ignoring it but I've not had a chance to look at it as yet.

digitalnexialist commented 8 months ago

29.2 was just released. For such a complex project, should we propose a manually verified package?

https://mirrors.ibiblio.org/gnu/emacs/windows/emacs-29/

pauby commented 7 months ago

I updated the package for 29.2, and it was approved. This PR is no longer needed.

Thanks for submitting it and apologies it took so long to get there.

pauby / ChocoPackages