paucarre / tiefvision

End-to-end deep learning image-similarity search engine
Apache License 2.0
765 stars 186 forks source link

Similarity db generator #44

Closed plippe closed 7 years ago

plippe commented 7 years ago

A single executable to to run image similarity. This will fetch or generate the required dependencies.

The image cropping has been removed for two main reasons:

Will be looking into injecting image paths next. ROOT/resources/dresses-db/master is quite limitting

plippe commented 7 years ago

The idea of removing the cropping and replacing it with custom paths allow people to run similarity on what ever type of image they wish. If cropping is deemed important, images can be cropped, and the script can be pointed to those cropped images. If cropping isn't a requirement, this step can be skipped.

The cropping is currently a task that is specific to category and requires human intervention. Those two points make it unpractical for production use.

Lastly, here are two similarities, one with cropping, and one without. I am unable to tell which is best.

screen shot 2016-12-01 at 15 09 54 screen shot 2016-12-01 at 15 10 13
plippe commented 7 years ago

Offline discussion points to the need to implement an input and output flag. This flag should be used if the default app behavior isn't wished. The flags' default values should be the current values.