search

paudetseis / Telewavesim

Teleseismic body wave modeling through stacks of (submarine/anisotropic) layers
https://paudetseis.github.io/Telewavesim/
MIT License
64 stars 18 forks source link

[JOSS review] telewavesim.elast.tri_tensor is the odd one out #16

Closed andreww closed 4 years ago

andreww commented 4 years ago

The function telewavesim.elast.tri_tensor returns a 3x3x3x3 numpy array representing the elasticity as a rank four tensor. All the other functions in this module (e.g. telewavesim.elast.iso_tensor return a 6x6 numpy array representing the elasticity in Voigt notation. It would be more consistent to return the elasticity in the same representation.

Also, what units should be used for density when normalising the elastic stiffnesses in GPa?

openjournals/joss-reviews#1818

paudetseis commented 4 years ago

telewavesim.elast.tri_tensor was incorporated into telewavesim.utils.set_tri_tensor to avoid the inconsistency brought up by the reviewer.

The units of density have been clarified.