search

paudetseis / Telewavesim

Teleseismic body wave modeling through stacks of (submarine/anisotropic) layers
https://paudetseis.github.io/Telewavesim/
MIT License
66 stars 18 forks source link

Find and link to dependencies #34

Closed brmather closed 5 years ago

brmather commented 5 years ago

Fix https://github.com/paudetseis/Telewavesim/issues/31

  1. Find lapack to link against in setup.py
  2. Find lapack again when on import in __init__.py
codecov-io commented 5 years ago

Codecov Report

Merging #34 into master will decrease coverage by 0.11%. The diff coverage is 46.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
- Coverage   55.98%   55.87%   -0.12%     
==========================================
  Files           9        9              
  Lines        1136     1149      +13     
==========================================
+ Hits          636      642       +6     
- Misses        500      507       +7
Impacted Files Coverage Δ
telewavesim/__init__.py 53.33% <46.15%> (-46.67%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cdc3875...f0919c8. Read the comment docs.

trichter commented 5 years ago

Thank you for this patch. Travis is giving green light and this fixes your installation, so I will merge it. Note that the code in __init__.py inside the except block is not triggered by our tests. As far as I understand the except block is a work-around if the lapack library is not correctly specified in the /etc/ld.so.conf.d folder or not set via $LD_LIBRARY_PATH variable.