search

paug / AndroidMakersApp

📱Official companion app for Android Makers by droidcon 🇫🇷
https://androidmakers.droidcon.com/
118 stars 27 forks source link

Use KMPAuth for login #189

Open enthuan opened 3 months ago

enthuan commented 3 months ago

I found this library and I think it's a good candidate to implement both Google Sign In and Apple Sign In. I will require an intermediate screen to select Google / Apple sign in

BONUS : Github sign in :)

https://github.com/mirzemehdi/KMPAuth?tab=readme-ov-file

martinbonnin commented 3 months ago

Would be awesome indeed. Passkeys would also be nice. Only thing is it binds us to Firebase auth on the backend, which I'm not 100% how to implement. I'll dig more!

enthuan commented 3 months ago

Yeah that was the only pain point here.To my opinion KMPauth could be a quick win to implement the current login system on iOS without dealing too much with Apple Sign in.Should I wait before doing this? I have the feeling that passkeys are more difficult to implement, but I may be wrong.Antoine RobiezLe 8 mars 2024 à 11:50, Martin Bonnin @.***> a écrit : Would be awesome indeed. Passkeys would also be nice. Only thing is it binds us to Firebase auth on the backend, which I'm not 100% how to implement. I'll dig more!

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

enthuan commented 3 months ago

https://github.com/twilio/twilio-verify-passkeys maybe with this ?

martinbonnin commented 3 months ago

Nevermind, I was wrong, we already use Firebase auth in the backend. It should work out of the box with Apple/GitHub/other as long as a firebase idToken is passed in the Authentication header. Go for it 👍

enthuan commented 2 months ago

It's not that easy to implement. KMPAuth doesn't work the same way as the Firebase unofficial lib. We can retrieve the 'stored' user with KMPAuth, it only manages (AFAIK) the flow of authentication and return a user once.

martinbonnin commented 2 months ago

We could probably "just" store the user locally or so... I was talking signin with @BoD yesterday and would be nice to have to sync bookmarks with the watch. Will dig a bit more. (editted with mandatory "just" :) )