search

paug / AndroidMakersApp

📱Official companion app for Android Makers by droidcon 🇫🇷
https://androidmakers.droidcon.com/
117 stars 27 forks source link

[Android] App crash on opening without internet #302

Open MaxMichel2 opened 1 month ago

MaxMichel2 commented 1 month ago

I noticed this by accident but opening the app without internet causes a crash on Android.

I'm interested in debugging and fixing this myself so I'll try to fix it in the near future.

martinbonnin commented 1 month ago

Thanks for the bug report and sorry for the delayed response, these last 2 days have been quite something! Please feel free to open a pull request if you find the root cause of the issue. FWIW, we have a few crashes like below in the Google play console. Might be a good place to start:

Exception y9.o: A network error (such as timeout, interrupted connection or unreachable host) has occurred.
  at com.google.android.gms.internal.firebase-auth-api.zzach.zza (com.google.firebase:firebase-auth@@22.3.1:4)
  at com.google.android.gms.internal.firebase-auth-api.zzadg.zza (com.google.firebase:firebase-auth@@22.3.1)
  at com.google.android.gms.internal.firebase-auth-api.zzacw.zza (com.google.firebase:firebase-auth@@22.3.1:6)
  at com.google.android.gms.internal.firebase-auth-api.zzacy.zza (com.google.firebase:firebase-auth@@22.3.1:2)
  at com.google.android.gms.internal.firebase-auth-api.zzacf.zza (com.google.firebase:firebase-auth@@22.3.1:2)
  at com.google.android.gms.internal.firebase-auth-api.zzyk.zza (com.google.firebase:firebase-auth@@22.3.1:2)
  at com.google.android.gms.internal.firebase-auth-api.zzadl.zza (com.google.firebase:firebase-auth@@22.3.1:1)
  at com.google.android.gms.internal.firebase-auth-api.zzacs.zza (com.google.firebase:firebase-auth@@22.3.1:9)
  at com.google.android.gms.internal.firebase-auth-api.zzyl.zzb (com.google.firebase:firebase-auth@@22.3.1:2)
  at com.google.android.gms.internal.firebase-auth-api.zzace.zzb (com.google.firebase:firebase-auth@@22.3.1:1)
  at com.google.android.gms.internal.firebase-auth-api.zzaar.zza (com.google.firebase:firebase-auth@@22.3.1:2)
  at com.google.android.gms.internal.firebase-auth-api.zzadi.run (com.google.firebase:firebase-auth@@22.3.1)
  at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1145)
  at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:644)
  at com.google.firebase.concurrent.CustomThreadFactory.lambda$newThread$0 (CustomThreadFactory.java:1)
  at java.lang.Thread.run (Thread.java:1012)
martinbonnin commented 1 month ago

@MaxMichel2 turns out we had the issue in another repo as well. I made a tentative ~fix~ workaround in #303