paukstelis / Octoprint-Cancelobject

104 stars 11 forks source link

Minor NavBar annoyance probably easy to fix #37

Closed PRGeno closed 5 years ago

PRGeno commented 5 years ago

I have the "Show active in NavBar" option unchecked because I have other information shown in the NavBar and adding the object information overflows the NavBar and makes a mess of the page.

That setting almost works as expected, except for one minor issue which occurs when a print ends. There must be a statement to refresh the NavBar with the phrase "Current Object: None" when the print ends, and this shows up in the NavBar regardless of the "Show active in NavBar" setting. This phrase is pretty useless and unfortunately stays there until the page is manually refreshed.

Is there a way this can be removed, as it really has no use, or at least is made to honor the "Show active in NavBar" setting?

paukstelis commented 5 years ago

Thanks. Will look into it.

paukstelis commented 5 years ago

Fix pushed, but untested. Please reinstall and give it a try.

PRGeno commented 5 years ago

After a quick test it appears to have worked as expected.

Thank you for the incredibly quick response