search

paul-carteron / happign

Happign allows you to use the APIs provided by the IGN (France) to download their public data.
https://paul-carteron.github.io/happign/
GNU General Public License v3.0
29 stars 2 forks source link

Consider delaying connection checking #5

Closed Enchufa2 closed 2 years ago

Enchufa2 commented 2 years ago

This package checks whether there's Internet connection .onLoad. As a consequence, building the package fails in package repositories which do not allow Internet connection during package building. See e.g. https://copr.fedorainfracloud.org/coprs/iucar/cran/package/R-CRAN-happign/. Please, consider delaying this check or completely avoiding it when the package is being installed (not sure whether this can be detected; maybe there's some env variable you could check).

paul-carteron commented 2 years ago

Hi I will completely remove the internet connection check. On the other hand, I will add a get_last_news function which will allow to have access to the RSS feed of geoservice.

Thanks for your comment

Enchufa2 commented 2 years ago

Thanks! (BTW, I added an incorrect URL above, corrected now).

paul-carteron commented 2 years ago

Hi @Enchufa2, I removed the connection when loading the package. I hope this will work for you.