search

paul-lrr / nifty-recognizer

node server and html files to connect the Deckedbuilder card recognizer to a streaming overlay
Other
38 stars 4 forks source link

Incorrect card IDs being sent for newer sets #9

Open BeyondTheVoid opened 4 years ago

BeyondTheVoid commented 4 years ago

Hi,

I've been trying to set up the nifty recogniser for a home streaming solution to play paper magic with friends. It's working fine with a lot of cards and I'm able to display the cards correctly I've been encountering a strange problem with any set released after Guilds of Ravnica. The cards will display correctly in deckedbuilder, but will send an incorrect id via nifty server. For example, the RNA card Skewer the Critics sends an id of 1235292, despite having a mulitverse id of 457259. The difference in ID varies from set to set, making a hack like an offset for newer sets not viable.

I've attached a file with examples, where I added some log info to the index.js in order to find out what was going on. I was wondering if this is an issue anyone else has experienced? I'll keep debugging and post if I find anything out in the meantime, but any info would be greatly appreciated.

Recogniser_Error_Notes.txt

paul-lrr commented 4 years ago

I have actually experienced this as well. As far as I can tell it is an actual issue with the deckedbuilder database. When new set come out, the multiverse ids are not known for sure until the cards show up in Gatherer, so many databases use temporary ids for new sets so they can publish them ASAP. My guess is that deckedbuilder uses these temp ids, but they haven't got around to actually updating them with the real multiverse ids when they are available.

I'm going to contact the deckedbuilder developers and see if this is something they can fix

BeyondTheVoid commented 4 years ago

Ah that makes sense, since they'll want to have them functional for preview season. If it does get fixed, that would be good. I've managed to have some success with it just using custom sets, so it's done the job. Thanks for reaching out to them, if they get back to you, I'd be interested in trying out the update. I'd like to look into something that can automatically post into a Discord chat to trigger the Scryfall bot as a back up, since most of the scene I use for games is for the board itself, will post back here if I have any success.