search

paul-michalik / g2o

g2o: A General Framework for Graph Optimization
http://openslam.org/g2o.html
0 stars 0 forks source link

Support g2o viewer build on windows #8

Closed PTavse closed 6 years ago

paul-michalik commented 6 years ago

Why reopen an already merged pull request? Please create a new one from a branch created for the purpose of the task.

OK, I apologize, my mistake. This is a new branch the name just sounds similar... What confuses me is that all the commits which were already merged on master are now part of this PR. From which commit have you branched?

PTavse commented 6 years ago

I guess i branched the code before these pull requests were merged. If I am not wrong i would have to rebase the branch? About the QGLViewer build, there could be two ways to provide the libraries: 1) Download and build the code while building g2o code as i did in the first commit. 2) We can just directly make the libraries available in "Thirdparty" folder and just set QGLVIEWERROOT to the path to Thirdparty folder, as ansuman suggested. Which one would you suggest?

paul-michalik commented 6 years ago

No, you have branched several days after the pull request were merged. What I don't understand is where you have branched from. You should have branched from master at 24db3a771df48fe26192e433504f4829597b97f2 but I don't see that commit at all. Strange, we need to get rid of this.

I'd prefer 1. possibility. Only this guarantees consistency across all dependencies...