search

paul-rouse / mysql-simple

A mid-level client library for the MySQL database, intended to be fast and easy to use.
Other
91 stars 35 forks source link

Add database and table name to UnexpectedNull #41

Closed danclien closed 6 years ago

paul-rouse commented 6 years ago

Can you please explain why you want to do this? Is it just for debugging, or do you want to catch the error and process the fields within your program? The reason I ask is that I think there may be a better way of doing it.

danclien commented 6 years ago

We write the UnexpectedNull to our logs when we encounter it. This was a quick fix we did to make tracking down the issue in our database easier.

paul-rouse commented 6 years ago

Thanks - I wondered if it was something like that.

I think it would be much better to put this information into the errMessage field, which is left empty at the moment in the case of UnexpectedNull. That way the ResultError type stays the same, so it can be done in a minor version bump, and we don't need to worry about consistency with the other constructors (which all have the same fields at present).

I'll make that change and release a new version in a few hours, and meanwhile I'll close this PR.

paul-rouse commented 6 years ago

Version I described released as 0.4.4 - thanks for the idea!

danclien commented 6 years ago

Thanks for the change. Much appreciated!

On Sat, Oct 21, 2017 at 3:02 PM, Paul Rouse notifications@github.com wrote:

Version I described released as 0.4.4 - thanks for the idea!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/paul-rouse/mysql-simple/pull/41#issuecomment-338428656, or mute the thread https://github.com/notifications/unsubscribe-auth/AAusIpJaddRnwq3dBOKWXWfTjZDbEr__ks5suk3cgaJpZM4QBag- .