search

paul-rouse / mysql-simple

A mid-level client library for the MySQL database, intended to be fast and easy to use.
Other
91 stars 35 forks source link

Fix build on ghc 8.4.x #56

Closed donsbot closed 2 years ago

donsbot commented 2 years ago

The English spelling isn't accepted until ghc 8.6 series. Caught by glean cI:

https://github.com/facebookincubator/Glean/runs/6646154634?check_suite_focus=true#step:18:704

donsbot commented 2 years ago

The recent commit facfb42200b1bd09400882256622391e5cf14707 introduced an accidental non-backwards compatible extension name, which causes build failures on 8.4.x series. This PR fixes it. Please merge, as this breaks the Glean CI.

paul-rouse commented 2 years ago

Fair enough - thanks. I'll merge and release.

I guess I should be more aggressive about the lower bound on base to limit which ghc versions can be used - I currently test new versions on 8.6.x and above, so I'd prefer users of older compilers to use older versions of mysql-simple!