Closed paul-thebaud closed 2 years ago
Merging #3 (2001632) into main (064eebd) will increase coverage by
0.17%
. The diff coverage is100.00%
.:exclamation: Current head 2001632 differs from pull request most recent head 02f4414. Consider uploading reports for the commit 02f4414 to get more accurate results
@@ Coverage Diff @@
## main #3 +/- ##
==========================================
+ Coverage 95.14% 95.32% +0.17%
==========================================
Files 24 25 +1
Lines 371 385 +14
Branches 71 73 +2
==========================================
+ Hits 353 367 +14
Misses 16 16
Partials 2 2
Impacted Files | Coverage Δ | |
---|---|---|
src/components/VPhoneInput.vue | 96.19% <100.00%> (+0.06%) |
:arrow_up: |
src/utils/countries/ip2cCountryGuesser.ts | 100.00% <100.00%> (ø) |
|
src/utils/countries/isPreferableCountryGuesser.ts | 100.00% <100.00%> (ø) |
|
src/utils/countries/memoIp2cCountryGuesser.ts | 100.00% <100.00%> (ø) |
|
...c/utils/countries/storageMemoIp2cCountryGuesser.ts | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 064eebd...02f4414. Read the comment docs.
Proposed Changes
PreferableCountryGuesser
which extends theCountryGuesser
interface: it adds asetPreference(country: CountryIso2): void
method to customize the preferred country (and so bypass the guess).MemoIp2cCountryGuesser
andStorageMemoIp2cCountryGuesser
are implementing this new interfacesetPreference
when the country changes (only if thecountryGuesser
is aPreferableCountryGuesser
)