search

paul-tqh-nguyen / arxiv_as_a_newspaper

arxiv.org portrayed as if it were a news paper.
0 stars 0 forks source link

Make sure out front end CLI calls "npm install" when necessary #13

Closed paul-tqh-nguyen closed 5 years ago

paul-tqh-nguyen commented 5 years ago

Our repo isn't going to hold all the libraries that we'll need installed for our app to be run.

We'll need to have npm install called when necessary.

If it's fast, then just call it all the time.

If it is not, figure out how to determine if it is necessary.

paul-tqh-nguyen commented 5 years ago

It takes about 10 seconds, so let's just call it every time for now.

We don't plan on leaving it this way forever, but we will wait for more motivation before making progress on detecting when it is necessary.

paul-tqh-nguyen commented 5 years ago

Solution Patch: https://github.com/paul-tqh-nguyen/arxiv_as_a_newspaper/commit/fdae3d0e2c0b1fe27777f0384aa8761f1c68db6c

This patch makes it so that we do an npm install prior to every front end server initialization.

paul-tqh-nguyen commented 5 years ago

NOTE: It takes 21s on the first installation.