paul-tqh-nguyen / reuters_topic_labelling

Deep learning to automatically label Reuter's articles with the relevant topics.
1 stars 0 forks source link

Abstract out a Classifier class #23

Closed paul-tqh-nguyen closed 4 years ago

paul-tqh-nguyen commented 4 years ago

In order to make progress on https://github.com/paul-tqh-nguyen/reuters_topic_labelling/issues/22 without throwing away our EEAP model implementation (it'd be nice to keep it around for posterity to demonstrate that it functions, though doesn't perform well on our dataset), it'd be useful to abstract out what is generally useful (which is a lot of it, e.g. all the interfaces for training, validating, saving out models, etc.).

We can do this via an abstract class.

https://docs.python.org/3/library/abc.html provides a way for us to define an abstract class.

This ticket is to abstract out what is generally useful.

paul-tqh-nguyen commented 4 years ago

https://github.com/paul-tqh-nguyen/reuters_topic_labelling/commit/3c12e6ec48609312b2065e90543b62e1a8ab4fb7 accomplishes this task.