search

paul / progress_bar

A Ruby terminal progress_bar
Do What The F*ck You Want To Public License
623 stars 49 forks source link

allow highline to 2.x.x versation #42

Closed ogidow closed 6 years ago

ogidow commented 6 years ago

Version 2.0.0 of highline gem has been released. The dependency on 1.x.x prevents users from upgrading to the 2.x.x series of highline.

paul commented 6 years ago

Have you tried this with 2.0.0 already? Does it seem to work OK? If progress_bar works with both, I'd like to see the version constraint relaxed to allow both.

paul commented 6 years ago

@ogidow I relaxed the specification on master to allow highline 2.x as well as 1.6+. Tests pass and it seems to work locally. Mind giving it a try? I'll make a new release once you've verified it works for you as well.

ogidow commented 6 years ago

@paul I tried it. There was no problem

paul commented 6 years ago

@ogidow Thanks for the report! I've released 1.3.0 to rubygems.