search

paul1956 / CSharpToVB

New version of CSharpToVB converter
MIT License
25 stars 9 forks source link

Underscores are generated for multiline statements when not necessary #13

Closed jnm2 closed 4 years ago

jnm2 commented 4 years ago

Source line: https://github.com/dotnet/roslyn/blob/c0a1d1ec94efc2b4fcc2334580c84741e10e45ef/src/EditorFeatures/CSharpTest/SimplifyInterpolation/SimplifyInterpolationTests.cs#L23

Expected:

        <Fact>

Actual:

        <Fact> _

Source lines: https://github.com/dotnet/roslyn/blob/c0a1d1ec94efc2b4fcc2334580c84741e10e45ef/src/EditorFeatures/CSharpTest/SimplifyInterpolation/SimplifyInterpolationTests.cs#L38-L39

Expected:

            Assert.Equal(
                {

Actual:

            Assert.Equal( _
                { _
paul1956 commented 4 years ago

There is/was a note in the readme about this, VS removed them then you open it. I put them there when there is a possibility of a blank line that C# allows but VB does not. I am open to looking at this again.

paul1956 commented 4 years ago

Many are fixed in 4.2.0.0, open new issue if you see more