paul1956 / CSharpToVB

New version of CSharpToVB converter
MIT License
25 stars 9 forks source link

Clicking Abort when there is a problem loading a .csproj file should not exit the app #8

Closed jnm2 closed 4 years ago

jnm2 commented 4 years ago

I want to leave the app open and try again after changing things on disk.

It's not clear that 'Retry' or 'Ignore' mean "stop opening the project and let me try again."

paul1956 commented 4 years ago

Abort usually means exit the app, the other 2 options let you make changes and don't exit. But in the case of MSBuild failures not sure what you could do. I have updated the title to explain abort.

jnm2 commented 4 years ago

In the case of MSBuild failures, couldn't the app stay open and be put in the same state as before the user clicked 'Open project'?

paul1956 commented 4 years ago

I need to look at this, trying to convert Project files was probably something I should not have tried.

paul1956 commented 4 years ago

This issue is fixed, why I can't open a project with MSBuild anymore is a mystery.