pauladaniel / calendardateselect

Automatically exported from code.google.com/p/calendardateselect
Other
0 stars 0 forks source link

this.clearDate() should fire onchange callback #152

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Create a CalendarDateSelect object with an onchange callback
2. Click the "clear" button on the calendar
3. Watch as your callback doesn't fire

Easy fix:

Call this.updateValue() inside of this.clearDate();

However, this may not be the best solution as there may be other callbacks
that don't fire (I'm not familiar enough with CalendarDateSelect to
enumerate them).

Also, this is a kinda sloppy method to begin with. Something like this
should be done by observing the input field.

Original issue reported on code.google.com by kau...@gmail.com on 16 Jan 2009 at 11:58

GoogleCodeExporter commented 8 years ago
My mistake, don't call this.updateValue(), just call this.callback("onchange"). 
You
probably knew this already though.

Original comment by kau...@gmail.com on 17 Jan 2009 at 1:13

GoogleCodeExporter commented 8 years ago
this has been fixed already, about two months ago. are you on the latest 
version? (I
added a test case to cds_test.html to verify the correct behavior, and the test 
is
passing)

Original comment by timchar...@gmail.com on 20 Feb 2009 at 5:57

GoogleCodeExporter commented 8 years ago
Tim, you're correct. I was using 1.12 when this was fixed in 1.13. Given that I
downloaded CalendarDateSelect manually about 2 days before I filed this report, 
I'm
not sure how I ended up with 1.12 when 1.13 was out. Apologies for the 
erroneous bug
report and any wasted time it may have caused you.

Original comment by kau...@gmail.com on 24 Feb 2009 at 3:27

GoogleCodeExporter commented 8 years ago
Great - thanks for verifying the fix.

Original comment by timchar...@gmail.com on 24 Feb 2009 at 4:55