paularmstrong / build-tracker

A set of tools to track the size of your build artifacts over time.
https://buildtracker.dev
MIT License
439 stars 27 forks source link

docs: Fix CLI docs link & specific applicationUrl #175

Closed paulirish closed 4 years ago

paulirish commented 4 years ago

Problem

two problems.

one was a 404 of docs. easy.

other is was that i first tried applicationUrl: 'https://lh-build-tracker.herokuapp.com/',. It turns out that trailing slash leads to some unexpected results, where the "API" returns HTML and it all goes haywire. :) I added a small console.log on the API response to see what was happening. Anyway, the fix seemed to be dropping the trailing slash. I figure leaving it out here may help future users. Up to you if you want a different fix :)

TODO

codecov-io commented 4 years ago

Codecov Report

Merging #175 into master will not change coverage by %. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #175   +/-   ##
=======================================
  Coverage   97.02%   97.02%           
=======================================
  Files         120      120           
  Lines        2923     2923           
  Branches      521      521           
=======================================
  Hits         2836     2836           
  Misses         83       83           
  Partials        4        4