search

paularmstrong / build-tracker

A set of tools to track the size of your build artifacts over time.
https://buildtracker.dev
MIT License
439 stars 27 forks source link

List item has orange background colour but no size #204

Open OliverJAsh opened 4 years ago

OliverJAsh commented 4 years ago

Problem

Steps to Reproduce

Compare builds in Build Tracker, e.g. https://unsplash-web-build-tracker.herokuapp.com/builds/799595d967a3eb03c7be2896523c70563ac707e0/f1afb6915414bac2dbb3d77c24730c24ae8bc571

Sometimes Build Tracker shows the difference for a list item with an orange background colour but no size:

image

Expected Result

A size + background colour (meaning there was a difference) or no size and no background colour (meaning there was no difference)

Actual Result

See above

paularmstrong commented 3 years ago

@OliverJAsh are you still seeing this? I think it was fixed in https://github.com/paularmstrong/build-tracker/commit/4600ebf86ce6173c67c859134f4a5f07e17fe1f2

paularmstrong commented 3 years ago

I found an instance of this in the currently deployed demo (which uses the main branch code): link. Definitely still a problem 👍🏻