paularmstrong / build-tracker

A set of tools to track the size of your build artifacts over time.
https://buildtracker.dev
MIT License
439 stars 27 forks source link

fix: increase branch name length to 256-char #208

Closed paularmstrong closed 4 years ago

paularmstrong commented 4 years ago

Problem

Some people use really long git branch names, sometimes automated systems do that. We currently limit branch names in the official database plugins to 64 characters.

Solution

Increase to 256 characters.

Fixes #205

Ideally in a longer term solution, we should include schema versions in the database to know what migrations need to be run. This is something we could investigate as a larger epic.

TODO

codecov-io commented 4 years ago

Codecov Report

Merging #208 into master will decrease coverage by 0.09%. The diff coverage is 69.23%.

@@            Coverage Diff             @@
##           master     #208      +/-   ##
==========================================
- Coverage   96.95%   96.85%   -0.10%     
==========================================
  Files         122      122              
  Lines        3021     3022       +1     
  Branches      492      494       +2     
==========================================
- Hits         2929     2927       -2     
- Misses         89       92       +3     
  Partials        3        3              
Impacted Files Coverage Ξ”
plugins/with-mysql/src/setup.ts 66.66% <55.55%> (-8.34%) :arrow_down:
plugins/with-mariadb/src/setup.ts 100.00% <100.00%> (ΓΈ)
plugins/with-postgres/src/setup.ts 100.00% <100.00%> (ΓΈ)
github-actions[bot] commented 4 years ago

⚠️: Group "Web App" failed the gzip budget size limit of 150 KiB by 3.69 KiB

View table | | e00fac7 | f5c2e80 | Ξ”1 | | :------ | ---------: | ---------: | --------------: | | All | 477.24 KiB | 478.25 KiB | 1.02 KiB (0.2%) | | Web App | 153.69 KiB | 153.69 KiB | ⚠️ 0 KiB (0.0%) |

View on Build Tracker