search

paularmstrong / build-tracker

A set of tools to track the size of your build artifacts over time.
https://buildtracker.dev
MIT License
439 stars 27 forks source link

Exception when hovering over graph #215

Closed OliverJAsh closed 3 years ago

OliverJAsh commented 3 years ago

Problem

Sometimes, when I hover over the graph, I get an error in my console and the whole app disappears.

gif

image

I believe the error originates from this line. Presumably, dataSeries does not contain a value at index revision.index. Why would this happen? 🤔

https://github.com/paularmstrong/build-tracker/blob/0d2074301dcebbb18f01c3d4a210774920254b03/src/app/src/components/Graph/HoverOverlay.tsx#L115

Steps to Reproduce

  1. https://unsplash-web-build-tracker.herokuapp.com/
  2. View builds in last year
  3. Hover

Expected Result

No error

Actual Result

Error as per above