search

paularmstrong / build-tracker

A set of tools to track the size of your build artifacts over time.
https://buildtracker.dev
MIT License
439 stars 27 forks source link

Upgrade `pg` to v8 to avoid issue with Node 14 #218

Open OliverJAsh opened 3 years ago

OliverJAsh commented 3 years ago

Problem

When using Postgres + Node 14, queries never resolve.

Steps to Reproduce

  1. Use Postgres + Node 14
  2. Request /api/builds/1

Expected Result

A response

Actual Result

Request hangs forever

I believe this is because of https://github.com/brianc/node-postgres/issues/2180. I suggest upgrading this dependency to v8.0.3 or above.

montogeek commented 3 years ago

It does solve it. @paularmstrong I can send a PR for that :)

paulirish commented 3 years ago

@paularmstrong I can send a PR for that :)

@montogeek that'd be useful to me, at least. :) i just ran into this

paulirish commented 3 years ago

btw this change will also need this.. at least to work on heroku. https://help.heroku.com/MDM23G46/why-am-i-getting-an-error-when-i-upgrade-to-pg-8