paulbrejla
commented
1 year ago Hi @Connum! I did not plan this yet but it should be pretty straightforward.
Necessary changes:
- Adapt loaders to be country-aware (including the model)
- Adapt API to be country-aware (adding country code to the path). This should probably be under a separate route (e.g. /v2) to remain backwards-compatible
- Adapt service layer + repository to be country aware
Feel free to create a PR for this, otherwise I will probably have time to look into this during the next weeks.
Cheers Paul
Is there any interest in expanding this to international (at least European) data? I see that in paulbrejla/ferien-api-data there's a subfolder
/de/, so it should be possible to add more data, but the API currently doesn't have a way to specify a country. I would be interested in supplying data for other European countries, if there was a way to query that via the API. Instead of Bundesländer, other countries have departements or counties or other regions, or could at least have one general file for national holidays, but that shouldn't be a problem I guess?