search

paulbrodersen / matplotlib_set_diagrams

Draw Euler diagrams and Venn diagrams with Matplotlib.
GNU General Public License v3.0
5 stars 1 forks source link

Python 3.9 not supported #2

Closed moi90 closed 1 month ago

moi90 commented 1 month ago

In _diagram_classes.py:155 you write type unions using the pipe operator. Union type expressions where only introduced in Python 3.10. However, pyproject.toml states requires-python = ">3.6".

I think the requires-python field should be updated to reflect this.

paulbrodersen commented 1 month ago

Thank you, great catch. If that is the only python 3.9 compatibility issue, then I will use the Union keyword instead of the pipe operator.

moi90 commented 1 month ago

I don't know if this is the only issue... 3.9 will meet its end-of-life in October 2025. You have to decide if you want to support it for this last year. :) I saw that you previously replaced the Union with the pipe operator in an earlier commit (and I agree that it looks much nicer).

moi90 commented 1 month ago

I created a pull request to address this compatibility issue. (The piping operator seemed to be the only problem for 3.9. The Matplotlib version that is installed with older versions of Python lacks the matplotlib.typing module, so 3.9 is the oldest working version.)

I dedicated a little bit of my time to this project, because I think it's awesome and was very helpful to me. :)

paulbrodersen commented 1 month ago

Sorry for the late reply -- I was in bed with bronchitis. I had a look at the PR; everything looks fine to me. So thank you very much for your time and your kind words! Stay awesome.