search

paulbutcher / ScalaMock

Native Scala mocking framework
http://scalamock.org/
MIT License
502 stars 99 forks source link

Force using correct mixin of MockFactory in async/sync tests #451

Closed nimatrueway closed 2 years ago

nimatrueway commented 2 years ago

Pull Request Checklist

Fixes

Fixes https://github.com/paulbutcher/ScalaMock/issues/371

Purpose

As been mentioned in README.md the trait AsyncMockFactory should be used with Async*Spec classes otherwise tests will be ignored silently.

This PR enforces this idea further, as users will receive feedback at compile time to help.

barkhorn commented 2 years ago

very cool, thanks for this PR, could you please confirm that you are happy with this:

nimatrueway commented 2 years ago

very cool, thanks for this PR, could you please confirm that you are happy with this:

  • [ ] I agree to licence my contributions under the MIT licence

Gladly done! I just added the checklist to PR's description.