paulbutcher / ScalaMock

Native Scala mocking framework

http://scalamock.org/

MIT License

502 stars 99 forks source link

Permit mocking stackable trait pattern in scala 3 #528

Open hughsimpson opened 1 month ago

hughsimpson commented 1 month ago

Pull Request Checklist

[x] I agree to licence my contributions under the MIT licence
[x] I have added copyright headers to new files
[x] I have added tests for any changed functionality

Fixes

Fixes mocking classes that implement the stackable trait pattern (i.e. abstract override def) in scala 3

hughsimpson commented 1 month ago

Maybe not the forum to say this, but other than https://github.com/paulbutcher/ScalaMock/pull/527 this was the only bug I've hit so far on migrating from scala 2 to scala 3, so absolutely incredible job on compatibility here.

hughsimpson commented 1 month ago

I appreciate there's a nuance here of 'do we really want to make it impossible to mock artifact methods?'. I think they're already essentially not unlockable? As in it would probably be pointless to try to use them in any mock. So I'm pretty sure that it's a legit forbid