search

paulcollett / react-masonry-css

React Masonry layout component powered by CSS, dependancy free
https://paulcollett.github.io/react-masonry-css/demo/
MIT License
962 stars 66 forks source link

Warning: Failed prop type: Invalid prop `breakpointCols` of type `number` supplied to `Masonry`, expected `object`. #45

Closed dandv closed 5 years ago

dandv commented 5 years ago

Just started using the library with Gatsby, pasted the example from the README, and I'm seeing this warning in the console. The layout works fine.

image

paulcollett commented 5 years ago

Thanks Dan. Good find!

Typical usage would be passing an object with breakpoint and column but a number to indicate a set amount of columns is also valid, and should not produce this error. I'll get this updated when I can, unless your able to submit a PR which would be most appreciated

On Tue, Oct 22, 2019 at 8:32 AM Dan Dascalescu notifications@github.com wrote:

Just started using the library with Gatsby, pasted the example from the README, and I'm seeing this warning in the console. The layout works fine.

[image: image] https://user-images.githubusercontent.com/33569/67302919-3f515c80-f4b7-11e9-9f2c-f30f163e8d97.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/paulcollett/react-masonry-css/issues/45?email_source=notifications&email_token=AAORBBTHXF25RR3T43X6LX3QP4MJZA5CNFSM4JDRRHZKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HTRIDTQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAORBBWF2RNH44JOBF5GFH3QP4MJZANCNFSM4JDRRHZA .

paulcollett commented 5 years ago

Has been fixed in: https://github.com/paulcollett/react-masonry-css/commit/724ad866805226d8ead5def41b92ba9abc46c2be

In this I've tightened up the documentation, handling of all props and laying down an interface for future features.