search

paulcpederson / focusin

Focusin/focusout polyfill for Firefox
ISC License
5 stars 1 forks source link

move polyfill to scoped function #3

Closed paulcpederson closed 9 years ago

jamiebuilds commented 9 years ago

Do you want to change the main field in the package.json?

paulcpederson commented 9 years ago

@thejameskyle to focusin-polyfill.js? I don't know, what do you think? My thought was that if people are loading it via npm for the client they are going to require it, so it's not much more work to call polyfill as well? What do you think?

jamiebuilds commented 9 years ago

Well, looking at npm download stats it looks like we're the only two using this. Idk if you need to optimize for people that don't yet exist. I do think this is the preferred api for polyfilling for npm users though

paulcpederson commented 9 years ago

@thejameskyle haha. Goood points. I like the explicit nature of .polyfill as I think it's less magic. Going to merge this and push 2.0.

paulcpederson commented 9 years ago

Leaving the main as this fixes your issue and I don't mind typing polyfill