search

pauldub / activity-watch-mode

Emacs plugin for automatic time tracking and metrics generated from your programming activity.
https://activitywatch.net
70 stars 9 forks source link

Customizable project name detection process #14

Closed VojtechStep closed 4 years ago

VojtechStep commented 4 years ago

Fixes #4

This PR allows the user to specify multiple ways of detecting the name of the project. I have included multiple resolvers based on Projectile and Magit, as those are the primary tools I use for interacting with project structures. I believe the process for adding custom resolvers is easy and reasonably documented.

I also removed projectile from dependencies, as it is now an optional dependency and the package works fine without it installed.

There was also one error I found in the implementation of a request callback, which may have affected performance, so it would probably be good to ping the issues about slowing down Emacs and ask whether this patch changes anything.

Let me know if there is anything missing.

pauldub commented 4 years ago

Hi @VojtechStep

Thank you very much for tackling this issue, I quite like the multiple resolvers architecture. With this in place I believe the package has a good level of adaptability to one's workflow.

I'll ping issues #7 and #8 to ask for more feedback after this feature is released.